diff options
| author | Cristian Ciocaltea <cristian.ciocaltea@collabora.com> | 2025-05-26 17:07:47 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-10-02 13:39:10 +0200 |
| commit | 4f9294613bb3925d1c333f05b8a93b972ee1065d (patch) | |
| tree | a3ae22000e61ac6f2df325b1d6c8543c14177f75 | |
| parent | 790b167e58570683d122f9f38520b247b917888c (diff) | |
| download | linux-4f9294613bb3925d1c333f05b8a93b972ee1065d.tar.gz linux-4f9294613bb3925d1c333f05b8a93b972ee1065d.tar.bz2 linux-4f9294613bb3925d1c333f05b8a93b972ee1065d.zip | |
ALSA: usb-audio: Remove unneeded wmb() in mixer_quirks
[ Upstream commit 9cea7425595697802e8d55a322a251999554b8b1 ]
Adding a memory barrier before wake_up() in
snd_usb_soundblaster_remote_complete() is supposed to ensure the write
to mixer->rc_code is visible in wait_event_interruptible() from
snd_usb_sbrc_hwdep_read().
However, this is not really necessary, since wake_up() is just a wrapper
over __wake_up() which already executes a full memory barrier before
accessing the state of the task to be waken up.
Drop the redundant call to wmb() and implicitly fix the checkpatch
complaint:
WARNING: memory barrier without comment
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250526-dualsense-alsa-jack-v1-8-1a821463b632@collabora.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | sound/usb/mixer_quirks.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c index 3156bb50f9ff..d50cd771356f 100644 --- a/sound/usb/mixer_quirks.c +++ b/sound/usb/mixer_quirks.c @@ -208,7 +208,6 @@ static void snd_usb_soundblaster_remote_complete(struct urb *urb) if (code == rc->mute_code) snd_usb_mixer_notify_id(mixer, rc->mute_mixer_id); mixer->rc_code = code; - wmb(); wake_up(&mixer->rc_waitq); } |