diff options
| author | Pali Rohár <pali@kernel.org> | 2022-05-04 18:57:39 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-05-12 12:30:30 +0200 |
| commit | 9e475a95c59b9d01dc8eaecc386fc3877d35fd85 (patch) | |
| tree | f01852da516e0a3375429b0d2d76432138881859 | |
| parent | 95bd4e10877c96e451186af58cc149a5f72ccc2c (diff) | |
| download | linux-9e475a95c59b9d01dc8eaecc386fc3877d35fd85.tar.gz linux-9e475a95c59b9d01dc8eaecc386fc3877d35fd85.tar.bz2 linux-9e475a95c59b9d01dc8eaecc386fc3877d35fd85.zip | |
PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ
commit 51f96e287c6f003d3bb29672811c757c5fbf0028 upstream.
It is possible that we receive spurious INTx interrupt. Check for the
return value of generic_handle_domain_irq() when processing INTx IRQ.
Link: https://lore.kernel.org/r/20220110015018.26359-6-kabel@kernel.org
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/pci/controller/pci-aardvark.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 5d6ed7a3816f..00fe1e6682ad 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1429,7 +1429,9 @@ static void advk_pcie_handle_int(struct advk_pcie *pcie) advk_writel(pcie, PCIE_ISR1_INTX_ASSERT(i), PCIE_ISR1_REG); - generic_handle_domain_irq(pcie->irq_domain, i); + if (generic_handle_domain_irq(pcie->irq_domain, i) == -EINVAL) + dev_err_ratelimited(&pcie->pdev->dev, "unexpected INT%c IRQ\n", + (char)i + 'A'); } } |