diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-01 12:09:28 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-22 14:22:02 +0200 |
| commit | 0b325d993995a321f6ab4e6c51f0504ec092bf5b (patch) | |
| tree | be7d415c32efc24dce597f2f4307b047a5601e4b | |
| parent | 5d38720661a4b9c87705c206a6081177ffb8ec1d (diff) | |
| download | linux-0b325d993995a321f6ab4e6c51f0504ec092bf5b.tar.gz linux-0b325d993995a321f6ab4e6c51f0504ec092bf5b.tar.bz2 linux-0b325d993995a321f6ab4e6c51f0504ec092bf5b.zip | |
irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions
[ Upstream commit ec8401a429ffee34ccf38cebf3443f8d5ae6cb0d ]
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
When kcalloc fails, it missing of_node_put() and results in refcount
leak. Fix this by goto out_put_node label.
Fixes: 52085d3f2028 ("irqchip/gic-v3: Dynamically allocate PPI partition descriptors")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-5-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/irqchip/irq-gic-v3.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 1269284461da..867a45aa0698 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -1864,7 +1864,7 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node) gic_data.ppi_descs = kcalloc(gic_data.ppi_nr, sizeof(*gic_data.ppi_descs), GFP_KERNEL); if (!gic_data.ppi_descs) - return; + goto out_put_node; nr_parts = of_get_child_count(parts_node); |