summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaor Dickman <maord@nvidia.com>2022-01-30 16:00:41 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-02-05 12:39:56 +0100
commit28929e393da4947f4993ebfa9dde5fb26925783d (patch)
tree1fb1dc019ad9c9d008203a74a32c9ad79eea9748
parenta4161e4861132d5b324746a260283e87f2d65daf (diff)
downloadlinux-28929e393da4947f4993ebfa9dde5fb26925783d.tar.gz
linux-28929e393da4947f4993ebfa9dde5fb26925783d.tar.bz2
linux-28929e393da4947f4993ebfa9dde5fb26925783d.zip
net/mlx5: E-Switch, Fix uninitialized variable modact
commit d8e5883d694bb053b19c4142a2d1f43a34f6fe2c upstream. The variable modact is not initialized before used in command modify header allocation which can cause command to fail. Fix by initializing modact with zeros. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 8f1e0b97cc70 ("net/mlx5: E-Switch, Mark miss packets with new chain id mapping") Signed-off-by: Maor Dickman <maord@nvidia.com> Reviewed-by: Roi Dayan <roid@nvidia.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
index e94233a12a32..df58cba37930 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/fs_chains.c
@@ -212,7 +212,7 @@ static int
create_chain_restore(struct fs_chain *chain)
{
struct mlx5_eswitch *esw = chain->chains->dev->priv.eswitch;
- char modact[MLX5_UN_SZ_BYTES(set_add_copy_action_in_auto)];
+ u8 modact[MLX5_UN_SZ_BYTES(set_add_copy_action_in_auto)] = {};
struct mlx5_fs_chains *chains = chain->chains;
enum mlx5e_tc_attr_to_reg chain_to_reg;
struct mlx5_modify_hdr *mod_hdr;