diff options
| author | Sergey Shtylyov <s.shtylyov@omp.ru> | 2022-01-24 21:55:03 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-08 18:35:19 +0100 |
| commit | 11dfe20342f0befa5a9083f6761552d7688adb92 (patch) | |
| tree | 86b146185b5f2f93346c610dd90bf407458cf6f1 | |
| parent | 9a258cb569364c28d8ff6fed7fe75f4ecda7ecd5 (diff) | |
| download | linux-11dfe20342f0befa5a9083f6761552d7688adb92.tar.gz linux-11dfe20342f0befa5a9083f6761552d7688adb92.tar.bz2 linux-11dfe20342f0befa5a9083f6761552d7688adb92.zip | |
EDAC/xgene: Fix deferred probing
commit dfd0dfb9a7cc04acf93435b440dd34c2ca7b4424 upstream.
The driver overrides error codes returned by platform_get_irq_optional()
to -EINVAL for some strange reason, so if it returns -EPROBE_DEFER, the
driver will fail the probe permanently instead of the deferred probing.
Switch to propagating the proper error codes to platform driver code
upwards.
[ bp: Massage commit message. ]
Fixes: 0d4429301c4a ("EDAC: Add APM X-Gene SoC EDAC driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220124185503.6720-3-s.shtylyov@omp.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/edac/xgene_edac.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index 2ccd1db5e98f..7197f9fa0245 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -1919,7 +1919,7 @@ static int xgene_edac_probe(struct platform_device *pdev) irq = platform_get_irq_optional(pdev, i); if (irq < 0) { dev_err(&pdev->dev, "No IRQ resource\n"); - rc = -EINVAL; + rc = irq; goto out_err; } rc = devm_request_irq(&pdev->dev, irq, |