summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSrinivas Neeli <srinivas.neeli@xilinx.com>2022-07-21 13:09:09 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-07-29 17:28:13 +0200
commit6f16a5390640807dde420ee5ccbc4c95577aea6a (patch)
tree80e6a03144869d9f32915a732e25e10cf34b79b6
parentea857726df55a2bfb54d76ee757270cb9776fc6c (diff)
downloadlinux-6f16a5390640807dde420ee5ccbc4c95577aea6a.tar.gz
linux-6f16a5390640807dde420ee5ccbc4c95577aea6a.tar.bz2
linux-6f16a5390640807dde420ee5ccbc4c95577aea6a.zip
gpio: gpio-xilinx: Fix integer overflow
[ Upstream commit 32c094a09d5829ad9b02cdf667569aefa8de0ea6 ] Current implementation is not able to configure more than 32 pins due to incorrect data type. So type casting with unsigned long to avoid it. Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs") Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/gpio/gpio-xilinx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index b6d3a57e27ed..7f8e2fed2988 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)
const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);
map[index] &= ~(0xFFFFFFFFul << offset);
- map[index] |= v << offset;
+ map[index] |= (unsigned long)v << offset;
}
static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)