diff options
| author | Leon Romanovsky <leonro@nvidia.com> | 2021-04-05 10:44:34 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-04-14 08:24:18 +0200 |
| commit | f666ad4f8d87e3a9189c2c9c4b995aaa6dbf3e3f (patch) | |
| tree | abe23c3713b6e161d0ea026c6fce5eec0d7bf0d8 | |
| parent | 44d03319fe77a323eafe7a51d302277e72d43798 (diff) | |
| download | linux-f666ad4f8d87e3a9189c2c9c4b995aaa6dbf3e3f.tar.gz linux-f666ad4f8d87e3a9189c2c9c4b995aaa6dbf3e3f.tar.bz2 linux-f666ad4f8d87e3a9189c2c9c4b995aaa6dbf3e3f.zip | |
RDMA/addr: Be strict with gid size
[ Upstream commit d1c803a9ccd7bd3aff5e989ccfb39ed3b799b975 ]
The nla_len() is less than or equal to 16. If it's less than 16 then end
of the "gid" buffer is uninitialized.
Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload")
Link: https://lore.kernel.org/r/20210405074434.264221-1-leon@kernel.org
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/infiniband/core/addr.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 8beed4197e73..c9e63c692b6e 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -76,7 +76,9 @@ static struct workqueue_struct *addr_wq; static const struct nla_policy ib_nl_addr_policy[LS_NLA_TYPE_MAX] = { [LS_NLA_TYPE_DGID] = {.type = NLA_BINARY, - .len = sizeof(struct rdma_nla_ls_gid)}, + .len = sizeof(struct rdma_nla_ls_gid), + .validation_type = NLA_VALIDATE_MIN, + .min = sizeof(struct rdma_nla_ls_gid)}, }; static inline bool ib_nl_is_good_ip_resp(const struct nlmsghdr *nlh) |