diff options
| author | Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2021-07-27 23:40:54 -0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-08-04 12:27:40 +0200 |
| commit | e0310bbeaaa283e14b39c9d669679be19c4ce94c (patch) | |
| tree | 7ccac6e91fd2a1462fce2399835579c906502e50 | |
| parent | 408614108abd50820fe961430529c3dc7ebe4fd1 (diff) | |
| download | linux-e0310bbeaaa283e14b39c9d669679be19c4ce94c.tar.gz linux-e0310bbeaaa283e14b39c9d669679be19c4ce94c.tar.bz2 linux-e0310bbeaaa283e14b39c9d669679be19c4ce94c.zip | |
sctp: fix return value check in __sctp_rcv_asconf_lookup
[ Upstream commit 557fb5862c9272ad9b21407afe1da8acfd9b53eb ]
As Ben Hutchings noticed, this check should have been inverted: the call
returns true in case of success.
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: 0c5dc070ff3d ("sctp: validate from_addr_param return")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | net/sctp/input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/input.c b/net/sctp/input.c index ab84ebf1af4a..db4f917aafd9 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1175,7 +1175,7 @@ static struct sctp_association *__sctp_rcv_asconf_lookup( if (unlikely(!af)) return NULL; - if (af->from_addr_param(&paddr, param, peer_port, 0)) + if (!af->from_addr_param(&paddr, param, peer_port, 0)) return NULL; return __sctp_lookup_association(net, laddr, &paddr, transportp); |