summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYan Zhao <yan.y.zhao@intel.com>2020-04-08 03:12:34 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-05-06 08:15:14 +0200
commit08e90b299d4ec663e044ce85288d8c15957836c7 (patch)
tree8f84a91e8ff942244dd39a9b1bb2da4f602b845d
parent44e2a98e2b58649b9bde0042975626bb1bea3ad9 (diff)
downloadlinux-08e90b299d4ec663e044ce85288d8c15957836c7.tar.gz
linux-08e90b299d4ec663e044ce85288d8c15957836c7.tar.bz2
linux-08e90b299d4ec663e044ce85288d8c15957836c7.zip
vfio: avoid possible overflow in vfio_iommu_type1_pin_pages
commit 0ea971f8dcd6dee78a9a30ea70227cf305f11ff7 upstream. add parentheses to avoid possible vaddr overflow. Fixes: a54eb55045ae ("vfio iommu type1: Add support for mediated devices") Signed-off-by: Yan Zhao <yan.y.zhao@intel.com> Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/vfio/vfio_iommu_type1.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index d864277ea16f..f471600985ff 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -593,7 +593,7 @@ static int vfio_iommu_type1_pin_pages(void *iommu_data,
continue;
}
- remote_vaddr = dma->vaddr + iova - dma->iova;
+ remote_vaddr = dma->vaddr + (iova - dma->iova);
ret = vfio_pin_page_external(dma, remote_vaddr, &phys_pfn[i],
do_accounting);
if (ret)