diff options
| author | Yu Kuai <yukuai3@huawei.com> | 2021-05-17 16:18:26 +0800 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2021-06-30 08:47:45 -0400 |
| commit | 0e486713779a03a3f8f72cc5b9edf02593c24ff4 (patch) | |
| tree | 0299183b291afc0f8fde3ef9eadad2c0153b09c4 | |
| parent | 456367b2419001243c320549ae0b7f3f26962a9f (diff) | |
| download | linux-0e486713779a03a3f8f72cc5b9edf02593c24ff4.tar.gz linux-0e486713779a03a3f8f72cc5b9edf02593c24ff4.tar.bz2 linux-0e486713779a03a3f8f72cc5b9edf02593c24ff4.zip | |
dmaengine: zynqmp_dma: Fix PM reference leak in zynqmp_dma_alloc_chan_resourc()
[ Upstream commit 8982d48af36d2562c0f904736b0fc80efc9f2532 ]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20210517081826.1564698-4-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/dma/xilinx/zynqmp_dma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index d47749a35863..84009c5e0f33 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -467,7 +467,7 @@ static int zynqmp_dma_alloc_chan_resources(struct dma_chan *dchan) struct zynqmp_dma_desc_sw *desc; int i, ret; - ret = pm_runtime_get_sync(chan->dev); + ret = pm_runtime_resume_and_get(chan->dev); if (ret < 0) return ret; |