diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2021-08-27 17:53:10 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-30 10:09:22 +0200 |
| commit | cf9138c966ddbb1475fdb662989316f7d5fdd818 (patch) | |
| tree | f1b1c65161b2a3a992cbed4d687a3ba96aa2d547 | |
| parent | a8e8b1481930e14cd424a3abe95f97df4c5570ae (diff) | |
| download | linux-cf9138c966ddbb1475fdb662989316f7d5fdd818.tar.gz linux-cf9138c966ddbb1475fdb662989316f7d5fdd818.tar.bz2 linux-cf9138c966ddbb1475fdb662989316f7d5fdd818.zip | |
platform/x86/intel: punit_ipc: Drop wrong use of ACPI_PTR()
[ Upstream commit 349bff48ae0f5f8aa2075d0bdc2091a30bd634f6 ]
ACPI_PTR() is more harmful than helpful. For example, in this case
if CONFIG_ACPI=n, the ID table left unused which is not what we want.
Instead of adding ifdeffery here and there, drop ACPI_PTR()
and unused acpi.h.
Fixes: fdca4f16f57d ("platform:x86: add Intel P-Unit mailbox IPC driver")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210827145310.76239-1-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/platform/x86/intel_punit_ipc.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c index ccb44f2eb240..af3a28623e86 100644 --- a/drivers/platform/x86/intel_punit_ipc.c +++ b/drivers/platform/x86/intel_punit_ipc.c @@ -8,7 +8,6 @@ * which provide mailbox interface for power management usage. */ -#include <linux/acpi.h> #include <linux/bitops.h> #include <linux/delay.h> #include <linux/device.h> @@ -335,7 +334,7 @@ static struct platform_driver intel_punit_ipc_driver = { .remove = intel_punit_ipc_remove, .driver = { .name = "intel_punit_ipc", - .acpi_match_table = ACPI_PTR(punit_ipc_acpi_ids), + .acpi_match_table = punit_ipc_acpi_ids, }, }; |