summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2020-01-23 10:11:13 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-02-05 21:22:51 +0000
commitb71636ee37fa8f318156f58c80ed460e53351e37 (patch)
treeb72382de77fdd1b557fc3e7ad6a94e182d5025a0
parent148a71a8ece874a30ee7aed13aeec9be8e3964bb (diff)
downloadlinux-b71636ee37fa8f318156f58c80ed460e53351e37.tar.gz
linux-b71636ee37fa8f318156f58c80ed460e53351e37.tar.bz2
linux-b71636ee37fa8f318156f58c80ed460e53351e37.zip
l2t_seq_next should increase position index
[ Upstream commit 66018a102f7756cf72db4d2704e1b93969d9d332 ] if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/net/ethernet/chelsio/cxgb4/l2t.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/l2t.c b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
index 1a407d3c1d67..e6fe2870137b 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/l2t.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/l2t.c
@@ -682,8 +682,7 @@ static void *l2t_seq_start(struct seq_file *seq, loff_t *pos)
static void *l2t_seq_next(struct seq_file *seq, void *v, loff_t *pos)
{
v = l2t_get_idx(seq, *pos);
- if (v)
- ++*pos;
+ ++(*pos);
return v;
}