diff options
| author | Aaron Conole <aconole@redhat.com> | 2022-10-25 06:50:17 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-11-03 23:56:56 +0900 |
| commit | 4175d6381f6f1c152a73183caf1c72b3d6909f31 (patch) | |
| tree | 5997c3ecaf410b9a77298150b294732c9326cc62 | |
| parent | 0667bb60000dbd9b6124ea700ebc3df49dce41c8 (diff) | |
| download | linux-4175d6381f6f1c152a73183caf1c72b3d6909f31.tar.gz linux-4175d6381f6f1c152a73183caf1c72b3d6909f31.tar.bz2 linux-4175d6381f6f1c152a73183caf1c72b3d6909f31.zip | |
openvswitch: switch from WARN to pr_warn
[ Upstream commit fd954cc1919e35cb92f78671cab6e42d661945a3 ]
As noted by Paolo Abeni, pr_warn doesn't generate any splat and can still
preserve the warning to the user that feature downgrade occurred. We
likely cannot introduce other kinds of checks / enforcement here because
syzbot can generate different genl versions to the datapath.
Reported-by: syzbot+31cde0bef4bbf8ba2d86@syzkaller.appspotmail.com
Fixes: 44da5ae5fbea ("openvswitch: Drop user features if old user space attempted to create datapath")
Cc: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Aaron Conole <aconole@redhat.com>
Acked-by: Ilya Maximets <i.maximets@ovn.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | net/openvswitch/datapath.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 41035ce0d23c..5dc517d64965 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -1560,7 +1560,8 @@ static void ovs_dp_reset_user_features(struct sk_buff *skb, struct genl_info *in if (IS_ERR(dp)) return; - WARN(dp->user_features, "Dropping previously announced user features\n"); + pr_warn("%s: Dropping previously announced user features\n", + ovs_dp_name(dp)); dp->user_features = 0; } |