diff options
| author | Johan Hovold <johan@kernel.org> | 2019-11-28 18:22:02 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-01 09:32:59 +0000 |
| commit | 7c3da77f252f9c67211c959653d9a2e6ca26f646 (patch) | |
| tree | de3c3a330da49ff9d971454d0e0fa60ec122792e | |
| parent | a5403dc796abb3267e0e0bedb11f77a407813d91 (diff) | |
| download | linux-7c3da77f252f9c67211c959653d9a2e6ca26f646.tar.gz linux-7c3da77f252f9c67211c959653d9a2e6ca26f646.tar.bz2 linux-7c3da77f252f9c67211c959653d9a2e6ca26f646.zip | |
rsi: fix memory leak on failed URB submission
commit 47768297481184932844ab01a86752ba31a38861 upstream.
Make sure to free the skb on failed receive-URB submission (e.g. on
disconnect or currently also due to a missing endpoint).
Fixes: a1854fae1414 ("rsi: improve RX packet handling in USB interface")
Cc: stable <stable@vger.kernel.org> # 4.17
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/net/wireless/rsi/rsi_91x_usb.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c index 94456679c9cc..75ae1da72cd7 100644 --- a/drivers/net/wireless/rsi/rsi_91x_usb.c +++ b/drivers/net/wireless/rsi/rsi_91x_usb.c @@ -338,8 +338,10 @@ static int rsi_rx_urb_submit(struct rsi_hw *adapter, u8 ep_num) rx_cb); status = usb_submit_urb(urb, GFP_KERNEL); - if (status) + if (status) { rsi_dbg(ERR_ZONE, "%s: Failed in urb submission\n", __func__); + dev_kfree_skb(skb); + } return status; } |