diff options
| author | Colin Ian King <colin.king@canonical.com> | 2019-11-19 11:36:40 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-04-21 09:06:37 +0200 |
| commit | 97684c062d8ebe0252cdb0549de3206d1577c6e1 (patch) | |
| tree | 1f3d77381c3869bfb6abbc7344184f214b0617b3 | |
| parent | 9651a7dd240cdf3c1f60c5d4ea9c9856c1605814 (diff) | |
| download | linux-97684c062d8ebe0252cdb0549de3206d1577c6e1.tar.gz linux-97684c062d8ebe0252cdb0549de3206d1577c6e1.tar.bz2 linux-97684c062d8ebe0252cdb0549de3206d1577c6e1.zip | |
ASoC: Intel: mrfld: fix incorrect check on p->sink
commit f5e056e1e46fcbb5f74ce560792aeb7d57ce79e6 upstream.
The check on p->sink looks bogus, I believe it should be p->source
since the following code blocks are related to p->source. Fix
this by replacing p->sink with p->source.
Fixes: 24c8d14192cc ("ASoC: Intel: mrfld: add DSP core controls")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Copy-paste error")
Link: https://lore.kernel.org/r/20191119113640.166940-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | sound/soc/intel/atom/sst-atom-controls.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c index baef461a99f1..f883c9340eee 100644 --- a/sound/soc/intel/atom/sst-atom-controls.c +++ b/sound/soc/intel/atom/sst-atom-controls.c @@ -1333,7 +1333,7 @@ int sst_send_pipe_gains(struct snd_soc_dai *dai, int stream, int mute) dai->capture_widget->name); w = dai->capture_widget; snd_soc_dapm_widget_for_each_source_path(w, p) { - if (p->connected && !p->connected(w, p->sink)) + if (p->connected && !p->connected(w, p->source)) continue; if (p->connect && p->source->power && |