diff options
| author | Robert Richter <rrichter@marvell.com> | 2020-02-12 13:03:39 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-02-19 19:54:05 +0100 |
| commit | c9f68a2d7f68a3f3b2d9bf9f4a2de908c5ad4233 (patch) | |
| tree | ecaa9d7ccb100ebcf62018abac24627558f3e994 | |
| parent | cd035856889a77dd7aa3194bc40fc02905ca62d2 (diff) | |
| download | linux-c9f68a2d7f68a3f3b2d9bf9f4a2de908c5ad4233.tar.gz linux-c9f68a2d7f68a3f3b2d9bf9f4a2de908c5ad4233.tar.bz2 linux-c9f68a2d7f68a3f3b2d9bf9f4a2de908c5ad4233.zip | |
EDAC/sysfs: Remove csrow objects on errors
commit 4d59588c09f2a2daedad2a544d4d1b602ab3a8af upstream.
All created csrow objects must be removed in the error path of
edac_create_csrow_objects(). The objects have been added as devices.
They need to be removed by doing a device_del() *and* put_device() call
to also free their memory. The missing put_device() leaves a memory
leak. Use device_unregister() instead of device_del() which properly
unregisters the device doing both.
Fixes: 7adc05d2dc3a ("EDAC/sysfs: Drop device references properly")
Signed-off-by: Robert Richter <rrichter@marvell.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Tested-by: John Garry <john.garry@huawei.com>
Cc: <stable@vger.kernel.org>
Link: https://lkml.kernel.org/r/20200212120340.4764-4-rrichter@marvell.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/edac/edac_mc_sysfs.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 0367554e7437..66907d9d58b0 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -447,8 +447,7 @@ error: csrow = mci->csrows[i]; if (!nr_pages_per_csrow(csrow)) continue; - - device_del(&mci->csrows[i]->dev); + device_unregister(&mci->csrows[i]->dev); } return err; |