summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSami Tolvanen <samitolvanen@google.com>2020-07-30 08:37:01 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-08-05 09:58:46 +0200
commit333e7d5ed10ca3d7bd37e5e3f3e2b72b2184bc26 (patch)
tree812fd2a9cd5d0e6c4c25e1b2a1f395d95e24baf9
parent67a153c6a469d8741a160ef45f22f2f39f45b8c3 (diff)
downloadlinux-333e7d5ed10ca3d7bd37e5e3f3e2b72b2184bc26.tar.gz
linux-333e7d5ed10ca3d7bd37e5e3f3e2b72b2184bc26.tar.bz2
linux-333e7d5ed10ca3d7bd37e5e3f3e2b72b2184bc26.zip
arm64/alternatives: move length validation inside the subsection
[ Upstream commit 966a0acce2fca776391823381dba95c40e03c339 ] Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement sequences") breaks LLVM's integrated assembler, because due to its one-pass design, it cannot compute instruction sequence lengths before the layout for the subsection has been finalized. This change fixes the build by moving the .org directives inside the subsection, so they are processed after the subsection layout is known. Fixes: f7b93d42945c ("arm64/alternatives: use subsections for replacement sequences") Signed-off-by: Sami Tolvanen <samitolvanen@google.com> Link: https://github.com/ClangBuiltLinux/linux/issues/1078 Link: https://lore.kernel.org/r/20200730153701.3892953-1-samitolvanen@google.com Signed-off-by: Will Deacon <will@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--arch/arm64/include/asm/alternative.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm64/include/asm/alternative.h b/arch/arm64/include/asm/alternative.h
index 12f0eb56a1cc..619db9b4c9d5 100644
--- a/arch/arm64/include/asm/alternative.h
+++ b/arch/arm64/include/asm/alternative.h
@@ -77,9 +77,9 @@ static inline void apply_alternatives_module(void *start, size_t length) { }
"663:\n\t" \
newinstr "\n" \
"664:\n\t" \
- ".previous\n\t" \
".org . - (664b-663b) + (662b-661b)\n\t" \
- ".org . - (662b-661b) + (664b-663b)\n" \
+ ".org . - (662b-661b) + (664b-663b)\n\t" \
+ ".previous\n" \
".endif\n"
#define __ALTERNATIVE_CFG_CB(oldinstr, feature, cfg_enabled, cb) \