summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Keeping <jkeeping@inmusicbrands.com>2025-02-24 12:18:30 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-04-07 10:05:46 +0200
commit1a8d68ca7752c5af1b7d526cd4a61301ca404114 (patch)
tree98804cf893e5e8d78da0526e57027002acb014c7
parent52d942a5302eefb3b7a3bfee310a5a33feeedc21 (diff)
downloadlinux-1a8d68ca7752c5af1b7d526cd4a61301ca404114.tar.gz
linux-1a8d68ca7752c5af1b7d526cd4a61301ca404114.tar.bz2
linux-1a8d68ca7752c5af1b7d526cd4a61301ca404114.zip
serial: 8250_dma: terminate correct DMA in tx_dma_flush()
commit a26503092c75abba70a0be2aa01145ecf90c2a22 upstream. When flushing transmit side DMA, it is the transmit channel that should be terminated, not the receive channel. Fixes: 9e512eaaf8f40 ("serial: 8250: Fix fifo underflow on flush") Cc: stable <stable@kernel.org> Reported-by: Wentao Guan <guanwentao@uniontech.com> Signed-off-by: John Keeping <jkeeping@inmusicbrands.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/20250224121831.1429323-1-jkeeping@inmusicbrands.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/serial/8250/8250_dma.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
index 0dd0ae76b90c..ad410e85effd 100644
--- a/drivers/tty/serial/8250/8250_dma.c
+++ b/drivers/tty/serial/8250/8250_dma.c
@@ -146,7 +146,7 @@ void serial8250_tx_dma_flush(struct uart_8250_port *p)
*/
dma->tx_size = 0;
- dmaengine_terminate_async(dma->rxchan);
+ dmaengine_terminate_async(dma->txchan);
}
int serial8250_rx_dma(struct uart_8250_port *p)