diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2024-09-23 10:38:11 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-04-10 14:33:42 +0200 |
| commit | 5b36f9e8fa542115e8ab99b37ac37939c2a4221f (patch) | |
| tree | b8190deb17fab75f9a82fb3922d8cc276fce44af | |
| parent | 16d6b2527f0d0bc77aa88a00b50e8ff109765d3e (diff) | |
| download | linux-5b36f9e8fa542115e8ab99b37ac37939c2a4221f.tar.gz linux-5b36f9e8fa542115e8ab99b37ac37939c2a4221f.tar.bz2 linux-5b36f9e8fa542115e8ab99b37ac37939c2a4221f.zip | |
ntb_perf: Delete duplicate dmaengine_unmap_put() call in perf_copy_chunk()
commit 4279e72cab31dd3eb8c89591eb9d2affa90ab6aa upstream.
The function call “dmaengine_unmap_put(unmap)” was used in an if branch.
The same call was immediately triggered by a subsequent goto statement.
Thus avoid such a call repetition.
This issue was detected by using the Coccinelle software.
Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/ntb/test/ntb_perf.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 5a7a02408166..04690897a067 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -839,10 +839,8 @@ static int perf_copy_chunk(struct perf_thread *pthr, dma_set_unmap(tx, unmap); ret = dma_submit_error(dmaengine_submit(tx)); - if (ret) { - dmaengine_unmap_put(unmap); + if (ret) goto err_free_resource; - } dmaengine_unmap_put(unmap); |