diff options
| author | Christian Brauner <brauner@kernel.org> | 2025-04-14 15:55:06 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-06-04 14:40:25 +0200 |
| commit | fc7846a7d5320d37cbc027f13043e0b58b345766 (patch) | |
| tree | 834fb8cb623c1be47087f64e1aab1c96b774a25e | |
| parent | 3939280be98ed943eb2a7b7fc74a3e77e061a213 (diff) | |
| download | linux-fc7846a7d5320d37cbc027f13043e0b58b345766.tar.gz linux-fc7846a7d5320d37cbc027f13043e0b58b345766.tar.bz2 linux-fc7846a7d5320d37cbc027f13043e0b58b345766.zip | |
coredump: fix error handling for replace_fd()
commit 95c5f43181fe9c1b5e5a4bd3281c857a5259991f upstream.
The replace_fd() helper returns the file descriptor number on success
and a negative error code on failure. The current error handling in
umh_pipe_setup() only works because the file descriptor that is replaced
is zero but that's pretty volatile. Explicitly check for a negative
error code.
Link: https://lore.kernel.org/20250414-work-coredump-v2-2-685bf231f828@kernel.org
Tested-by: Luca Boccassi <luca.boccassi@gmail.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/coredump.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/fs/coredump.c b/fs/coredump.c index 4d332f147137..2e2b66aed59d 100644 --- a/fs/coredump.c +++ b/fs/coredump.c @@ -493,7 +493,9 @@ static int umh_pipe_setup(struct subprocess_info *info, struct cred *new) { struct file *files[2]; struct coredump_params *cp = (struct coredump_params *)info->data; - int err = create_pipe_files(files, 0); + int err; + + err = create_pipe_files(files, 0); if (err) return err; @@ -501,10 +503,13 @@ static int umh_pipe_setup(struct subprocess_info *info, struct cred *new) err = replace_fd(0, files[0], 0); fput(files[0]); + if (err < 0) + return err; + /* and disallow core files too */ current->signal->rlim[RLIMIT_CORE] = (struct rlimit){1, 1}; - return err; + return 0; } void do_coredump(const kernel_siginfo_t *siginfo) |