summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Chen <peter.chen@cixtech.com>2025-06-19 09:34:13 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-07-10 15:59:52 +0200
commitc2b47b8df7741fd457b37611474f3c5ac16fd70a (patch)
tree89ebde8a859dd8c2fb2d68ddf9a3655a4e9db59a
parent4b1eb5121ffcaa7f92d34a10c6096233cad968f1 (diff)
downloadlinux-c2b47b8df7741fd457b37611474f3c5ac16fd70a.tar.gz
linux-c2b47b8df7741fd457b37611474f3c5ac16fd70a.tar.bz2
linux-c2b47b8df7741fd457b37611474f3c5ac16fd70a.zip
usb: cdnsp: do not disable slot for disabled slot
commit 7e2c421ef88e9da9c39e01496b7f5b0b354b42bc upstream. It doesn't need to do it, and the related command event returns 'Slot Not Enabled Error' status. Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") Cc: stable <stable@kernel.org> Suggested-by: Hongliang Yang <hongliang.yang@cixtech.com> Reviewed-by: Fugang Duan <fugang.duan@cixtech.com> Signed-off-by: Peter Chen <peter.chen@cixtech.com> Link: https://lore.kernel.org/r/20250619013413.35817-1-peter.chen@cixtech.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/cdns3/cdnsp-ring.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
index 6247584cb939..c9ad4280f4ba 100644
--- a/drivers/usb/cdns3/cdnsp-ring.c
+++ b/drivers/usb/cdns3/cdnsp-ring.c
@@ -772,7 +772,9 @@ static int cdnsp_update_port_id(struct cdnsp_device *pdev, u32 port_id)
}
if (port_id != old_port) {
- cdnsp_disable_slot(pdev);
+ if (pdev->slot_id)
+ cdnsp_disable_slot(pdev);
+
pdev->active_port = port;
cdnsp_enable_slot(pdev);
}