diff options
| author | Jeremy Kerr <jk@codeconstruct.com.au> | 2024-02-15 15:53:08 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-03-01 13:26:38 +0100 |
| commit | c22ad76cfc43a2c7923de1a9acc0d05b9fa2c63c (patch) | |
| tree | 919acf27fd8c183b9912b63ccb232f858ca6b409 | |
| parent | ea33b816691255d1d5eeb7f5a02f2acf6a556393 (diff) | |
| download | linux-c22ad76cfc43a2c7923de1a9acc0d05b9fa2c63c.tar.gz linux-c22ad76cfc43a2c7923de1a9acc0d05b9fa2c63c.tar.bz2 linux-c22ad76cfc43a2c7923de1a9acc0d05b9fa2c63c.zip | |
net: mctp: put sock on tag allocation failure
[ Upstream commit 9990889be14288d4f1743e4768222d5032a79c27 ]
We may hold an extra reference on a socket if a tag allocation fails: we
optimistically allocate the sk_key, and take a ref there, but do not
drop if we end up not using the allocated key.
Ensure we're dropping the sock on this failure by doing a proper unref
rather than directly kfree()ing.
Fixes: de8a6b15d965 ("net: mctp: add an explicit reference from a mctp_sk_key to sock")
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/ce9b61e44d1cdae7797be0c5e3141baf582d23a0.1707983487.git.jk@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | net/mctp/route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mctp/route.c b/net/mctp/route.c index 68be8f2b622d..256bf0b89e6c 100644 --- a/net/mctp/route.c +++ b/net/mctp/route.c @@ -663,7 +663,7 @@ struct mctp_sk_key *mctp_alloc_local_tag(struct mctp_sock *msk, spin_unlock_irqrestore(&mns->keys_lock, flags); if (!tagbits) { - kfree(key); + mctp_key_unref(key); return ERR_PTR(-EBUSY); } |