summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaulo Alcantara <pc@manguebit.com>2024-04-02 16:34:02 -0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-04-10 16:28:34 +0200
commitf9414004798d9742c1af23a1d839fe6a9503751c (patch)
tree8d3c1e6602ac7c8c123deb84f0ab6d24ff2dcd46
parent494c91e1e9413b407d12166a61b84200d4d54fac (diff)
downloadlinux-f9414004798d9742c1af23a1d839fe6a9503751c.tar.gz
linux-f9414004798d9742c1af23a1d839fe6a9503751c.tar.bz2
linux-f9414004798d9742c1af23a1d839fe6a9503751c.zip
smb: client: fix potential UAF in smb2_is_network_name_deleted()
commit 63981561ffd2d4987807df4126f96a11e18b0c1d upstream. Skip sessions that are being teared down (status == SES_EXITING) to avoid UAF. Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/smb/client/smb2ops.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index 3c471dc90659..2291081653a8 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -2437,6 +2437,8 @@ smb2_is_network_name_deleted(char *buf, struct TCP_Server_Info *server)
spin_lock(&cifs_tcp_ses_lock);
list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
if (tcon->tid == le32_to_cpu(shdr->Id.SyncId.TreeId)) {
spin_lock(&tcon->tc_lock);