summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-11-15 12:13:58 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-12-05 13:54:32 +0100
commit9ff46e1d444e8e6105c2b6d3268096d90a31b0a1 (patch)
tree99078c7e3b87cf627f10645255a668641007b690
parent674ba43944dab8e8f87434e25d9d10c5152584bc (diff)
downloadlinux-9ff46e1d444e8e6105c2b6d3268096d90a31b0a1.tar.gz
linux-9ff46e1d444e8e6105c2b6d3268096d90a31b0a1.tar.bz2
linux-9ff46e1d444e8e6105c2b6d3268096d90a31b0a1.zip
cifs: unlock on error in smb3_reconfigure()
[ Upstream commit cda88d2fef7aa7de80b5697e8009fcbbb436f42d ] Unlock before returning if smb3_sync_session_ctx_passwords() fails. Fixes: 7e654ab7da03 ("cifs: during remount, make sure passwords are in sync") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Bharath SM <bharathsm@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/smb/client/fs_context.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c
index e84660b48d53..e9fe48a3625b 100644
--- a/fs/smb/client/fs_context.c
+++ b/fs/smb/client/fs_context.c
@@ -978,8 +978,10 @@ static int smb3_reconfigure(struct fs_context *fc)
* later stage
*/
rc = smb3_sync_session_ctx_passwords(cifs_sb, ses);
- if (rc)
+ if (rc) {
+ mutex_unlock(&ses->session_mutex);
return rc;
+ }
/*
* now that allocations for passwords are done, commit them