diff options
| author | Suma Hegde <suma.hegde@amd.com> | 2025-08-07 10:06:37 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-10-29 14:09:00 +0100 |
| commit | 782977c0d8ba432b6fd3d5d0d87016a523ec1c69 (patch) | |
| tree | b9135039a882a65c6e1a90617fc237942566379e | |
| parent | ca44ae51b99c0388d60a7879bce5fc0eafe4f52f (diff) | |
| download | linux-782977c0d8ba432b6fd3d5d0d87016a523ec1c69.tar.gz linux-782977c0d8ba432b6fd3d5d0d87016a523ec1c69.tar.bz2 linux-782977c0d8ba432b6fd3d5d0d87016a523ec1c69.zip | |
platform/x86/amd/hsmp: Ensure sock->metric_tbl_addr is non-NULL
commit 2c78fb287e1f430b929f2e49786518350d15605c upstream.
If metric table address is not allocated, accessing metrics_bin will
result in a NULL pointer dereference, so add a check.
Fixes: 5150542b8ec5 ("platform/x86/amd/hsmp: add support for metrics tbl")
Signed-off-by: Suma Hegde <suma.hegde@amd.com>
Link: https://lore.kernel.org/r/20250807100637.952729-1-suma.hegde@amd.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
[ Minor context change fixed. ]
Signed-off-by: Alva Lan <alvalan9@foxmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/platform/x86/amd/hsmp.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/platform/x86/amd/hsmp.c b/drivers/platform/x86/amd/hsmp.c index 8fcf38eed7f0..66deb475f807 100644 --- a/drivers/platform/x86/amd/hsmp.c +++ b/drivers/platform/x86/amd/hsmp.c @@ -569,6 +569,11 @@ static ssize_t hsmp_metric_tbl_read(struct file *filp, struct kobject *kobj, if (!sock) return -EINVAL; + if (!sock->metric_tbl_addr) { + dev_err(sock->dev, "Metrics table address not available\n"); + return -ENOMEM; + } + /* Do not support lseek(), reads entire metric table */ if (count < bin_attr->size) { dev_err(sock->dev, "Wrong buffer size\n"); |