diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-10-08 18:08:58 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-11-02 22:15:23 +0900 |
| commit | 800101f6ab9d3ee4f315be7e6b4761e036530288 (patch) | |
| tree | 8cad1c26b92030d9426312fa9789ae9253148a14 | |
| parent | f21623b8446735b5e2ac5f8ee69b8743177d7b19 (diff) | |
| download | linux-800101f6ab9d3ee4f315be7e6b4761e036530288.tar.gz linux-800101f6ab9d3ee4f315be7e6b4761e036530288.tar.bz2 linux-800101f6ab9d3ee4f315be7e6b4761e036530288.zip | |
btrfs: tree-checker: fix bounds check in check_inode_extref()
commit e92c2941204de7b62e9c2deecfeb9eaefe54a22a upstream.
The parentheses for the unlikely() annotation were put in the wrong
place so it means that the condition is basically never true and the
bounds checking is skipped.
Fixes: aab9458b9f00 ("btrfs: tree-checker: add inode extref checks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/btrfs/tree-checker.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c index 986b1612d5b0..3bb7a376bd3f 100644 --- a/fs/btrfs/tree-checker.c +++ b/fs/btrfs/tree-checker.c @@ -1785,7 +1785,7 @@ static int check_inode_extref(struct extent_buffer *leaf, struct btrfs_inode_extref *extref = (struct btrfs_inode_extref *)ptr; u16 namelen; - if (unlikely(ptr + sizeof(*extref)) > end) { + if (unlikely(ptr + sizeof(*extref) > end)) { inode_ref_err(leaf, slot, "inode extref overflow, ptr %lu end %lu inode_extref size %zu", ptr, end, sizeof(*extref)); |