diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2025-02-07 22:16:09 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-01-08 10:15:03 +0100 |
| commit | d579cc549298a02ba90b7a6d20a2ba8e160f3f31 (patch) | |
| tree | b2f42d81f916ce8ad9ce135e6d621cfedf1061e6 | |
| parent | 6b60113d770233d0d6a06a0b4cc16e5b258db8a7 (diff) | |
| download | linux-d579cc549298a02ba90b7a6d20a2ba8e160f3f31.tar.gz linux-d579cc549298a02ba90b7a6d20a2ba8e160f3f31.tar.bz2 linux-d579cc549298a02ba90b7a6d20a2ba8e160f3f31.zip | |
hrtimers: Make hrtimer_update_function() less expensive
commit 2ea97b76d6712bfb0408e5b81ffd7bc4551d3153 upstream.
The sanity checks in hrtimer_update_function() are expensive for high
frequency usage like in the io/uring code due to locking.
Hide the sanity checks behind CONFIG_PROVE_LOCKING, which has a decent
chance to be enabled on a regular basis for testing.
Fixes: 8f02e3563bb5 ("hrtimers: Introduce hrtimer_update_function()")
Reported-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/87ikpllali.ffs@tglx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | include/linux/hrtimer.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h index 39fbeb64a7da..1e186449dd04 100644 --- a/include/linux/hrtimer.h +++ b/include/linux/hrtimer.h @@ -348,6 +348,7 @@ static inline int hrtimer_callback_running(struct hrtimer *timer) static inline void hrtimer_update_function(struct hrtimer *timer, enum hrtimer_restart (*function)(struct hrtimer *)) { +#ifdef CONFIG_PROVE_LOCKING guard(raw_spinlock_irqsave)(&timer->base->cpu_base->lock); if (WARN_ON_ONCE(hrtimer_is_queued(timer))) @@ -355,7 +356,7 @@ static inline void hrtimer_update_function(struct hrtimer *timer, if (WARN_ON_ONCE(!function)) return; - +#endif timer->function = function; } |