diff options
| author | Chia-I Wu <olvaffe@gmail.com> | 2025-07-17 23:38:15 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-12-18 14:00:09 +0100 |
| commit | 9ab439c0de1c0ee4fbf68eebc7e72a40d01b638a (patch) | |
| tree | 9f613c01733aec01d221c5a918415e40b862f8d8 | |
| parent | ca2e7fdad7c683b64821c94a58b9b68733214dad (diff) | |
| download | linux-9ab439c0de1c0ee4fbf68eebc7e72a40d01b638a.tar.gz linux-9ab439c0de1c0ee4fbf68eebc7e72a40d01b638a.tar.bz2 linux-9ab439c0de1c0ee4fbf68eebc7e72a40d01b638a.zip | |
panthor: save task pid and comm in panthor_group
[ Upstream commit 33b9cb6dcda2520600ac4fec725946af32c2e586 ]
We would like to report them on gpu errors.
We choose to save the info on panthor_group_create rather than on
panthor_open because, when the two differ, we are more interested in the
task that created the group.
Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250718063816.1452123-3-olvaffe@gmail.com
Stable-dep-of: eec7e23d848d ("drm/panthor: Prevent potential UAF in group creation")
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/gpu/drm/panthor/panthor_sched.c | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c index 99ce0948f2ba..35c4a86fe305 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -641,6 +641,15 @@ struct panthor_group { size_t kbo_sizes; } fdinfo; + /** @task_info: Info of current->group_leader that created the group. */ + struct { + /** @task_info.pid: pid of current->group_leader */ + pid_t pid; + + /** @task_info.comm: comm of current->group_leader */ + char comm[TASK_COMM_LEN]; + } task_info; + /** @state: Group state. */ enum panthor_group_state state; @@ -3391,6 +3400,14 @@ err_free_queue: return ERR_PTR(ret); } +static void group_init_task_info(struct panthor_group *group) +{ + struct task_struct *task = current->group_leader; + + group->task_info.pid = task->pid; + get_task_comm(group->task_info.comm, task); +} + static void add_group_kbo_sizes(struct panthor_device *ptdev, struct panthor_group *group) { @@ -3542,6 +3559,8 @@ int panthor_group_create(struct panthor_file *pfile, add_group_kbo_sizes(group->ptdev, group); spin_lock_init(&group->fdinfo.lock); + group_init_task_info(group); + return gid; err_put_group: |