diff options
| author | Johan Hovold <johan@kernel.org> | 2025-11-17 17:12:58 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2026-01-23 11:21:35 +0100 |
| commit | b3bbbf9da38c2735dc25f50e62775216dfd756f6 (patch) | |
| tree | eed4c27ccbcf165746b6b1aaa33ecfeb2341d854 | |
| parent | 30352277d8e09c972436f883a5efd1f1b763ac14 (diff) | |
| download | linux-b3bbbf9da38c2735dc25f50e62775216dfd756f6.tar.gz linux-b3bbbf9da38c2735dc25f50e62775216dfd756f6.tar.bz2 linux-b3bbbf9da38c2735dc25f50e62775216dfd756f6.zip | |
dmaengine: ti: k3-udma: fix device leak on udma lookup
commit 430f7803b69cd5e5694e5dfc884c6628870af36e upstream.
Make sure to drop the reference taken when looking up the UDMA platform
device.
Note that holding a reference to a platform device does not prevent its
driver data from going away so there is no point in keeping the
reference after the lookup helper returns.
Fixes: d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
Fixes: 1438cde8fe9c ("dmaengine: ti: k3-udma: add missing put_device() call in of_xudma_dev_get()")
Cc: stable@vger.kernel.org # 5.6: 1438cde8fe9c
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251117161258.10679-17-johan@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/dma/ti/k3-udma-private.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/ti/k3-udma-private.c b/drivers/dma/ti/k3-udma-private.c index 05228bf00033..624360423ef1 100644 --- a/drivers/dma/ti/k3-udma-private.c +++ b/drivers/dma/ti/k3-udma-private.c @@ -42,9 +42,9 @@ struct udma_dev *of_xudma_dev_get(struct device_node *np, const char *property) } ud = platform_get_drvdata(pdev); + put_device(&pdev->dev); if (!ud) { pr_debug("UDMA has not been probed\n"); - put_device(&pdev->dev); return ERR_PTR(-EPROBE_DEFER); } |