diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2023-04-18 15:57:47 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-05-11 23:11:35 +0900 |
| commit | 83b4e3d878ea6be9aec1d5a1ab177c766c64d1a0 (patch) | |
| tree | 62e38abf47d8289bb3710e6f351535770e259ccb | |
| parent | c8c9c50268729bf35f6c9bb1205f490db920454e (diff) | |
| download | linux-83b4e3d878ea6be9aec1d5a1ab177c766c64d1a0.tar.gz linux-83b4e3d878ea6be9aec1d5a1ab177c766c64d1a0.tar.bz2 linux-83b4e3d878ea6be9aec1d5a1ab177c766c64d1a0.zip | |
dm flakey: fix a crash with invalid table line
commit 98dba02d9a93eec11bffbb93c7c51624290702d2 upstream.
This command will crash with NULL pointer dereference:
dmsetup create flakey --table \
"0 `blockdev --getsize /dev/ram0` flakey /dev/ram0 0 0 1 2 corrupt_bio_byte 512"
Fix the crash by checking if arg_name is non-NULL before comparing it.
Cc: stable@vger.kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/md/dm-flakey.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c index 7efbdb42cf3b..3b34270ce607 100644 --- a/drivers/md/dm-flakey.c +++ b/drivers/md/dm-flakey.c @@ -124,9 +124,9 @@ static int parse_features(struct dm_arg_set *as, struct flakey_c *fc, * Direction r or w? */ arg_name = dm_shift_arg(as); - if (!strcasecmp(arg_name, "w")) + if (arg_name && !strcasecmp(arg_name, "w")) fc->corrupt_bio_rw = WRITE; - else if (!strcasecmp(arg_name, "r")) + else if (arg_name && !strcasecmp(arg_name, "r")) fc->corrupt_bio_rw = READ; else { ti->error = "Invalid corrupt bio direction (r or w)"; |