summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2023-10-24 11:42:21 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-11-02 09:36:59 +0100
commit51617780599746f507f46398d583c3ec3b83e07f (patch)
tree6fe50bd838bae5a3c14a289afd78360cd9f9ff81
parent25de47d0d6e740b230813c3e1381c6d0f4306b81 (diff)
downloadlinux-51617780599746f507f46398d583c3ec3b83e07f.tar.gz
linux-51617780599746f507f46398d583c3ec3b83e07f.tar.bz2
linux-51617780599746f507f46398d583c3ec3b83e07f.zip
perf/core: Fix potential NULL deref
commit a71ef31485bb51b846e8db8b3a35e432cc15afb5 upstream. Smatch is awesome. Fixes: 32671e3799ca ("perf: Disallow mis-matched inherited group reads") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--kernel/events/core.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c
index b3d800738fc5..f2f4d2b3beee 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -13383,7 +13383,8 @@ static int inherit_group(struct perf_event *parent_event,
!perf_get_aux_event(child_ctr, leader))
return -EINVAL;
}
- leader->group_generation = parent_event->group_generation;
+ if (leader)
+ leader->group_generation = parent_event->group_generation;
return 0;
}