summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2024-09-23 10:38:11 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-04-10 14:37:42 +0200
commit2e6df032a0b678fc444e303acebd37e1cbb79e64 (patch)
tree4d188d37671a1274a406a6cdcfda8ee18c6d666b
parent3820d20d51fd2ea7bba2a0dc389322fe03b913d2 (diff)
downloadlinux-2e6df032a0b678fc444e303acebd37e1cbb79e64.tar.gz
linux-2e6df032a0b678fc444e303acebd37e1cbb79e64.tar.bz2
linux-2e6df032a0b678fc444e303acebd37e1cbb79e64.zip
ntb_perf: Delete duplicate dmaengine_unmap_put() call in perf_copy_chunk()
commit 4279e72cab31dd3eb8c89591eb9d2affa90ab6aa upstream. The function call “dmaengine_unmap_put(unmap)” was used in an if branch. The same call was immediately triggered by a subsequent goto statement. Thus avoid such a call repetition. This issue was detected by using the Coccinelle software. Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support") Cc: stable@vger.kernel.org Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Jon Mason <jdmason@kudzu.us> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/ntb/test/ntb_perf.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 72bc1d017a46..dfd175f79e8f 100644
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -839,10 +839,8 @@ static int perf_copy_chunk(struct perf_thread *pthr,
dma_set_unmap(tx, unmap);
ret = dma_submit_error(dmaengine_submit(tx));
- if (ret) {
- dmaengine_unmap_put(unmap);
+ if (ret)
goto err_free_resource;
- }
dmaengine_unmap_put(unmap);