diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2024-02-01 21:01:02 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-02-16 19:14:31 +0100 |
| commit | 3183d7aa418b69462179016e711cc34a0220dc70 (patch) | |
| tree | 73a58d3544557498dd9bcc934f1b256fc9e6e3c6 | |
| parent | a18ae02db4d5a4129739bbe44396b0e946192d0a (diff) | |
| download | linux-3183d7aa418b69462179016e711cc34a0220dc70.tar.gz linux-3183d7aa418b69462179016e711cc34a0220dc70.tar.bz2 linux-3183d7aa418b69462179016e711cc34a0220dc70.zip | |
bcachefs: time_stats: Check for last_event == 0 when updating freq stats
commit 7b508b323b2ec45be59769bd4e4aeba729c52cf6 upstream.
This fixes spurious outliers in the frequency stats.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/bcachefs/util.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/bcachefs/util.c b/fs/bcachefs/util.c index 84b142fcc3df..3b7c349f2665 100644 --- a/fs/bcachefs/util.c +++ b/fs/bcachefs/util.c @@ -362,14 +362,15 @@ static inline void bch2_time_stats_update_one(struct bch2_time_stats *stats, bch2_quantiles_update(&stats->quantiles, duration); } - if (time_after64(end, stats->last_event)) { + if (stats->last_event && time_after64(end, stats->last_event)) { freq = end - stats->last_event; mean_and_variance_update(&stats->freq_stats, freq); mean_and_variance_weighted_update(&stats->freq_stats_weighted, freq); stats->max_freq = max(stats->max_freq, freq); stats->min_freq = min(stats->min_freq, freq); - stats->last_event = end; } + + stats->last_event = end; } static noinline void bch2_time_stats_clear_buffer(struct bch2_time_stats *stats, |