diff options
author | Daniel Starke <daniel.starke@siemens.com> | 2024-04-24 07:48:41 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-06-12 11:02:55 +0200 |
commit | 46f52c89a7e7d2691b97a9728e4591d071ca8abc (patch) | |
tree | 2487a1bd7bf81b19898fb47120458dd18f2301ef /drivers/accessibility | |
parent | dbff5f0bfb2416b8b55c105ddbcd4f885e98fada (diff) | |
download | linux-46f52c89a7e7d2691b97a9728e4591d071ca8abc.tar.gz linux-46f52c89a7e7d2691b97a9728e4591d071ca8abc.tar.bz2 linux-46f52c89a7e7d2691b97a9728e4591d071ca8abc.zip |
tty: n_gsm: fix possible out-of-bounds in gsm0_receive()
commit 47388e807f85948eefc403a8a5fdc5b406a65d5a upstream.
Assuming the following:
- side A configures the n_gsm in basic option mode
- side B sends the header of a basic option mode frame with data length 1
- side A switches to advanced option mode
- side B sends 2 data bytes which exceeds gsm->len
Reason: gsm->len is not used in advanced option mode.
- side A switches to basic option mode
- side B keeps sending until gsm0_receive() writes past gsm->buf
Reason: Neither gsm->state nor gsm->len have been reset after
reconfiguration.
Fix this by changing gsm->count to gsm->len comparison from equal to less
than. Also add upper limit checks against the constant MAX_MRU in
gsm0_receive() and gsm1_receive() to harden against memory corruption of
gsm->len and gsm->mru.
All other checks remain as we still need to limit the data according to the
user configuration and actual payload size.
Reported-by: j51569436@gmail.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218708
Tested-by: j51569436@gmail.com
Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20240424054842.7741-1-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/accessibility')
0 files changed, 0 insertions, 0 deletions