summaryrefslogtreecommitdiff
path: root/drivers/android/binder/freeze.rs
diff options
context:
space:
mode:
authorAlice Ryhl <aliceryhl@google.com>2025-10-07 09:39:53 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-10-13 11:06:20 +0200
commitb5ce7a5cc50f4c283d0bfa5cc24fe864cb9a3400 (patch)
treed75cb41665726d11a715c8e8ace9d85bd28fd586 /drivers/android/binder/freeze.rs
parent99559e5bb4c6795824b6531ad61519c1d9500079 (diff)
downloadlinux-b5ce7a5cc50f4c283d0bfa5cc24fe864cb9a3400.tar.gz
linux-b5ce7a5cc50f4c283d0bfa5cc24fe864cb9a3400.tar.bz2
linux-b5ce7a5cc50f4c283d0bfa5cc24fe864cb9a3400.zip
rust_binder: report freeze notification only when fully frozen
Binder only sends out freeze notifications when ioctl_freeze() completes and the process has become fully frozen. However, if a freeze notification is registered during the freeze operation, then it registers an initial state of 'frozen'. This is a problem because if the freeze operation fails, then the listener is not told about that state change, leading to lost updates. Signed-off-by: Alice Ryhl <aliceryhl@google.com> Acked-by: Carlos Llamas <cmllamas@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/android/binder/freeze.rs')
-rw-r--r--drivers/android/binder/freeze.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/android/binder/freeze.rs b/drivers/android/binder/freeze.rs
index e304aceca7f3..220de35ae85a 100644
--- a/drivers/android/binder/freeze.rs
+++ b/drivers/android/binder/freeze.rs
@@ -121,7 +121,7 @@ impl DeliverToRead for FreezeMessage {
writer.write_payload(&self.cookie.0)?;
Ok(true)
} else {
- let is_frozen = freeze.node.owner.inner.lock().is_frozen;
+ let is_frozen = freeze.node.owner.inner.lock().is_frozen.is_fully_frozen();
if freeze.last_is_frozen == Some(is_frozen) {
return Ok(true);
}
@@ -254,7 +254,7 @@ impl Process {
);
return Err(EINVAL);
}
- let is_frozen = freeze.node.owner.inner.lock().is_frozen;
+ let is_frozen = freeze.node.owner.inner.lock().is_frozen.is_fully_frozen();
if freeze.is_clearing || freeze.last_is_frozen != Some(is_frozen) {
// Immediately send another FreezeMessage.
clear_msg = Some(FreezeMessage::init(alloc, cookie));