diff options
| author | Zijun Hu <quic_zijuhu@quicinc.com> | 2024-07-02 22:51:51 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-08-03 08:49:39 +0200 |
| commit | 3dcd0673e47664bc6c719ad47dadac6d55d5950d (patch) | |
| tree | 2f861f68215480a71421bb0061c381fa0b56e3e2 /drivers/base | |
| parent | 4aac65f39c828083df7a47ccdb3a88a3a6a25bd9 (diff) | |
| download | linux-3dcd0673e47664bc6c719ad47dadac6d55d5950d.tar.gz linux-3dcd0673e47664bc6c719ad47dadac6d55d5950d.tar.bz2 linux-3dcd0673e47664bc6c719ad47dadac6d55d5950d.zip | |
devres: Fix memory leakage caused by driver API devm_free_percpu()
commit bd50a974097bb82d52a458bd3ee39fb723129a0c upstream.
It will cause memory leakage when use driver API devm_free_percpu()
to free memory allocated by devm_alloc_percpu(), fixed by using
devres_release() instead of devres_destroy() within devm_free_percpu().
Fixes: ff86aae3b411 ("devres: add devm_alloc_percpu()")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/1719931914-19035-3-git-send-email-quic_zijuhu@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base')
| -rw-r--r-- | drivers/base/devres.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 641ca9581ecf..f9add2ecdc55 100644 --- a/drivers/base/devres.c +++ b/drivers/base/devres.c @@ -1221,7 +1221,11 @@ EXPORT_SYMBOL_GPL(__devm_alloc_percpu); */ void devm_free_percpu(struct device *dev, void __percpu *pdata) { - WARN_ON(devres_destroy(dev, devm_percpu_release, devm_percpu_match, + /* + * Use devres_release() to prevent memory leakage as + * devm_free_pages() does. + */ + WARN_ON(devres_release(dev, devm_percpu_release, devm_percpu_match, (__force void *)pdata)); } EXPORT_SYMBOL_GPL(devm_free_percpu); |