summaryrefslogtreecommitdiff
path: root/drivers/block/virtio_blk.c
diff options
context:
space:
mode:
authorLiequan Che <cheliequan@inspur.com>2024-12-02 19:56:38 +0800
committerJens Axboe <axboe@kernel.dk>2024-12-03 15:06:27 -0700
commitb2e382ae12a63560fca35050498e19e760adf8c0 (patch)
treecc00d51758d9d62c18cd27e8cfb32d3db7610d2a /drivers/block/virtio_blk.c
parent3c93e4e4a2aeb92ea99e1eac3e1180f5ed49538c (diff)
downloadlinux-b2e382ae12a63560fca35050498e19e760adf8c0.tar.gz
linux-b2e382ae12a63560fca35050498e19e760adf8c0.tar.bz2
linux-b2e382ae12a63560fca35050498e19e760adf8c0.zip
bcache: revert replacing IS_ERR_OR_NULL with IS_ERR again
Commit 028ddcac477b ("bcache: Remove unnecessary NULL point check in node allocations") leads a NULL pointer deference in cache_set_flush(). 1721 if (!IS_ERR_OR_NULL(c->root)) 1722 list_add(&c->root->list, &c->btree_cache); >From the above code in cache_set_flush(), if previous registration code fails before allocating c->root, it is possible c->root is NULL as what it is initialized. __bch_btree_node_alloc() never returns NULL but c->root is possible to be NULL at above line 1721. This patch replaces IS_ERR() by IS_ERR_OR_NULL() to fix this. Fixes: 028ddcac477b ("bcache: Remove unnecessary NULL point check in node allocations") Signed-off-by: Liequan Che <cheliequan@inspur.com> Cc: stable@vger.kernel.org Cc: Zheng Wang <zyytlz.wz@163.com> Reviewed-by: Mingzhe Zou <mingzhe.zou@easystack.cn> Signed-off-by: Coly Li <colyli@suse.de> Link: https://lore.kernel.org/r/20241202115638.28957-1-colyli@suse.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block/virtio_blk.c')
0 files changed, 0 insertions, 0 deletions