summaryrefslogtreecommitdiff
path: root/drivers/block
diff options
context:
space:
mode:
authorKairui Song <kasong@tencent.com>2025-01-07 14:54:46 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-01-23 17:22:58 +0100
commit902ef8f16d5ca77edc77c30656be54186c1e99b7 (patch)
tree65d0417f36de35e395c1ecd1a082c2ca701a5eb3 /drivers/block
parent07c956f7904b24748fc940a675a8f63a2da7f803 (diff)
downloadlinux-902ef8f16d5ca77edc77c30656be54186c1e99b7.tar.gz
linux-902ef8f16d5ca77edc77c30656be54186c1e99b7.tar.bz2
linux-902ef8f16d5ca77edc77c30656be54186c1e99b7.zip
zram: fix potential UAF of zram table
commit 212fe1c0df4a150fb6298db2cfff267ceaba5402 upstream. If zram_meta_alloc failed early, it frees allocated zram->table without setting it NULL. Which will potentially cause zram_meta_free to access the table if user reset an failed and uninitialized device. Link: https://lkml.kernel.org/r/20250107065446.86928-1-ryncsn@gmail.com Fixes: 74363ec674cb ("zram: fix uninitialized ZRAM not releasing backing device") Signed-off-by: Kairui Song <kasong@tencent.com> Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/block')
-rw-r--r--drivers/block/zram/zram_drv.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index bf83a104086c..76b326ddd75c 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1349,6 +1349,7 @@ static bool zram_meta_alloc(struct zram *zram, u64 disksize)
zram->mem_pool = zs_create_pool(zram->disk->disk_name);
if (!zram->mem_pool) {
vfree(zram->table);
+ zram->table = NULL;
return false;
}