diff options
| author | Tianjia Zhang <tianjia.zhang@linux.alibaba.com> | 2020-10-05 22:52:12 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-29 09:57:44 +0100 |
| commit | dddb49f4152a9f2908e212b6e1fc357818cfee2c (patch) | |
| tree | a48fbb90581c502fdfe38bff6de3ad1a6aa75737 /drivers/char | |
| parent | b2a98fec2d1ee06483f7668d07b5ac9a21433363 (diff) | |
| download | linux-dddb49f4152a9f2908e212b6e1fc357818cfee2c.tar.gz linux-dddb49f4152a9f2908e212b6e1fc357818cfee2c.tar.bz2 linux-dddb49f4152a9f2908e212b6e1fc357818cfee2c.zip | |
ipmi_si: Fix wrong return value in try_smi_init()
[ Upstream commit 8fe7990ceda8597e407d06bffc4bdbe835a93ece ]
On an error exit path, a negative error code should be returned
instead of a positive return value.
Fixes: 90b2d4f15ff7 ("ipmi_si: Remove hacks for adding a dummy platform devices")
Cc: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Message-Id: <20201005145212.84435-1-tianjia.zhang@linux.alibaba.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/ipmi/ipmi_si_intf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 6b9a0593d2eb..b6e7df9e8850 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -1977,7 +1977,7 @@ static int try_smi_init(struct smi_info *new_smi) /* Do this early so it's available for logs. */ if (!new_smi->io.dev) { pr_err("IPMI interface added with no device\n"); - rv = EIO; + rv = -EIO; goto out_err; } |