diff options
| author | Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp> | 2024-06-27 15:31:09 +0900 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-08-03 08:54:14 +0200 |
| commit | 2b1aec0e6c1b919a44ad8343d293a6be96c7439e (patch) | |
| tree | bdb52cae87f48beef6ed761e1486510499d65f56 /drivers/char | |
| parent | 5a7c16a8b393b2037cda54765650bff6a871a095 (diff) | |
| download | linux-2b1aec0e6c1b919a44ad8343d293a6be96c7439e.tar.gz linux-2b1aec0e6c1b919a44ad8343d293a6be96c7439e.tar.bz2 linux-2b1aec0e6c1b919a44ad8343d293a6be96c7439e.zip | |
char: tpm: Fix possible memory leak in tpm_bios_measurements_open()
commit 5d8e2971e817bb64225fc0b6327a78752f58a9aa upstream.
In tpm_bios_measurements_open(), get_device() is called on the device
embedded in struct tpm_chip. In the error path, however, put_device() is
not called. This results in a reference count leak, which prevents the
device from being properly released. This commit makes sure to call
put_device() when the seq_open() call fails.
Cc: stable@vger.kernel.org # +v4.18
Fixes: 9b01b5356629 ("tpm: Move shared eventlog functions to common.c")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/tpm/eventlog/common.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/char/tpm/eventlog/common.c b/drivers/char/tpm/eventlog/common.c index 639c3f395a5a..4c0bbba64ee5 100644 --- a/drivers/char/tpm/eventlog/common.c +++ b/drivers/char/tpm/eventlog/common.c @@ -47,6 +47,8 @@ static int tpm_bios_measurements_open(struct inode *inode, if (!err) { seq = file->private_data; seq->private = chip; + } else { + put_device(&chip->dev); } return err; |