diff options
| author | Chengfeng Ye <cyeaa@connect.ust.hk> | 2021-11-04 06:38:31 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 08:47:33 +0100 |
| commit | 41cfcf37e799bd6d479cb527d67b3a437f2ba8ea (patch) | |
| tree | 8889454f72a9ce6a8c344ac85e1cc9ada24c1697 /drivers/crypto | |
| parent | 050ba77574e4c9a8c08312cb30a113afb12c12af (diff) | |
| download | linux-41cfcf37e799bd6d479cb527d67b3a437f2ba8ea.tar.gz linux-41cfcf37e799bd6d479cb527d67b3a437f2ba8ea.tar.bz2 linux-41cfcf37e799bd6d479cb527d67b3a437f2ba8ea.zip | |
crypto: qce - fix uaf on qce_ahash_register_one
[ Upstream commit b4cb4d31631912842eb7dce02b4350cbb7562d5e ]
Pointer base points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing base before free tmpl.
Fixes: ec8f5d8f ("crypto: qce - Qualcomm crypto engine driver")
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/qce/sha.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c index 47e114ac09d0..ff1e788f9276 100644 --- a/drivers/crypto/qce/sha.c +++ b/drivers/crypto/qce/sha.c @@ -544,8 +544,8 @@ static int qce_ahash_register_one(const struct qce_ahash_def *def, ret = crypto_register_ahash(alg); if (ret) { - kfree(tmpl); dev_err(qce->dev, "%s registration failed\n", base->cra_name); + kfree(tmpl); return ret; } |