diff options
| author | Chenghai Huang <huangchenghai2@huawei.com> | 2025-09-13 18:57:54 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-10-15 12:04:04 +0200 |
| commit | 7226a0650ad5705bd8d39a11be270fa21ed1e6a5 (patch) | |
| tree | 34d8b65aedb0300d7bb8288ae8f043fdf3334a00 /drivers/crypto | |
| parent | 779d3b6f2d32c5f1da6163e959abe1e1ffe2945b (diff) | |
| download | linux-7226a0650ad5705bd8d39a11be270fa21ed1e6a5.tar.gz linux-7226a0650ad5705bd8d39a11be270fa21ed1e6a5.tar.bz2 linux-7226a0650ad5705bd8d39a11be270fa21ed1e6a5.zip | |
crypto: hisilicon/qm - set NULL to qm->debug.qm_diff_regs
[ Upstream commit f0cafb02de883b3b413d34eb079c9680782a9cc1 ]
When the initialization of qm->debug.acc_diff_reg fails,
the probe process does not exit. However, after qm->debug.qm_diff_regs is
freed, it is not set to NULL. This can lead to a double free when the
remove process attempts to free it again. Therefore, qm->debug.qm_diff_regs
should be set to NULL after it is freed.
Fixes: 8be091338971 ("crypto: hisilicon/debugfs - Fix debugfs uninit process issue")
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/crypto')
| -rw-r--r-- | drivers/crypto/hisilicon/debugfs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/debugfs.c index 45e130b901eb..17eb236e9ee4 100644 --- a/drivers/crypto/hisilicon/debugfs.c +++ b/drivers/crypto/hisilicon/debugfs.c @@ -888,6 +888,7 @@ static int qm_diff_regs_init(struct hisi_qm *qm, dfx_regs_uninit(qm, qm->debug.qm_diff_regs, ARRAY_SIZE(qm_diff_regs)); ret = PTR_ERR(qm->debug.acc_diff_regs); qm->debug.acc_diff_regs = NULL; + qm->debug.qm_diff_regs = NULL; return ret; } |