diff options
| author | Krzysztof Kozlowski <krzk@kernel.org> | 2020-08-27 09:07:42 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-29 09:57:29 +0100 |
| commit | 64a9f5a30fbb0adcf11321eedfc3c41e7b4fa32b (patch) | |
| tree | fbfbc39b2f85a45d3e18f9e425a7cc4828adbe16 /drivers/edac | |
| parent | 4d86328e42c3e6f1aecd4e32c4980def0b717227 (diff) | |
| download | linux-64a9f5a30fbb0adcf11321eedfc3c41e7b4fa32b.tar.gz linux-64a9f5a30fbb0adcf11321eedfc3c41e7b4fa32b.tar.bz2 linux-64a9f5a30fbb0adcf11321eedfc3c41e7b4fa32b.zip | |
EDAC/aspeed: Fix handling of platform_get_irq() error
[ Upstream commit afce6996943be265fa39240b67025cfcb1bcdfb1 ]
platform_get_irq() returns a negative error number on error. In such a
case, comparison to 0 would pass the check therefore check the return
value properly, whether it is negative.
[ bp: Massage commit message. ]
Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Stefan Schaeckeler <schaecsn@gmx.net>
Link: https://lkml.kernel.org/r/20200827070743.26628-1-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/edac')
| -rw-r--r-- | drivers/edac/aspeed_edac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/edac/aspeed_edac.c b/drivers/edac/aspeed_edac.c index 5634437bb39d..66669f9d690b 100644 --- a/drivers/edac/aspeed_edac.c +++ b/drivers/edac/aspeed_edac.c @@ -209,8 +209,8 @@ static int config_irq(void *ctx, struct platform_device *pdev) /* register interrupt handler */ irq = platform_get_irq(pdev, 0); dev_dbg(&pdev->dev, "got irq %d\n", irq); - if (!irq) - return -ENODEV; + if (irq < 0) + return irq; rc = devm_request_irq(&pdev->dev, irq, mcr_isr, IRQF_TRIGGER_HIGH, DRV_NAME, ctx); |