summaryrefslogtreecommitdiff
path: root/drivers/firmware
diff options
context:
space:
mode:
authorMukesh Ojha <mukesh.ojha@oss.qualcomm.com>2025-08-07 18:14:51 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-11-13 15:34:02 -0500
commit27568eeee66d9091b4cbd9c0f24bc7e042e9144a (patch)
treedb49af38afd214b69bf526b0673c6fa623abf8ab /drivers/firmware
parentafc13decf32b6844ec39f9bc4665f0ed3229defc (diff)
downloadlinux-27568eeee66d9091b4cbd9c0f24bc7e042e9144a.tar.gz
linux-27568eeee66d9091b4cbd9c0f24bc7e042e9144a.tar.bz2
linux-27568eeee66d9091b4cbd9c0f24bc7e042e9144a.zip
firmware: qcom: scm: preserve assign_mem() error return value
[ Upstream commit 121fcf3c871181edce0708a49d2397cedd6ad21f ] When qcom_scm_assign_mem() fails, the error value is currently being overwritten after it is logged, resulting in the loss of the original error code. Fix this by retaining and returning the original error value as intended. Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/r/20250807124451.2623019-1-mukesh.ojha@oss.qualcomm.com Signed-off-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/qcom/qcom_scm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 23aefbf6fca5..1da16bc79391 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -1093,7 +1093,7 @@ int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz,
if (ret) {
dev_err(__scm->dev,
"Assign memory protection call failed %d\n", ret);
- return -EINVAL;
+ return ret;
}
*srcvm = next_vm;