summaryrefslogtreecommitdiff
path: root/drivers/firmware
diff options
context:
space:
mode:
authorMukesh Ojha <mukesh.ojha@oss.qualcomm.com>2025-08-07 18:14:51 +0530
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-11-13 15:36:45 -0500
commit168787897cb6020dbb01a05ad03973c75520ba38 (patch)
tree4f2d201913c27c0abe826c02e230f6c24277261a /drivers/firmware
parent71ba3ef2fcb7841b5818502410c6fea76dc3df35 (diff)
downloadlinux-168787897cb6020dbb01a05ad03973c75520ba38.tar.gz
linux-168787897cb6020dbb01a05ad03973c75520ba38.tar.bz2
linux-168787897cb6020dbb01a05ad03973c75520ba38.zip
firmware: qcom: scm: preserve assign_mem() error return value
[ Upstream commit 121fcf3c871181edce0708a49d2397cedd6ad21f ] When qcom_scm_assign_mem() fails, the error value is currently being overwritten after it is logged, resulting in the loss of the original error code. Fix this by retaining and returning the original error value as intended. Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/r/20250807124451.2623019-1-mukesh.ojha@oss.qualcomm.com Signed-off-by: Bjorn Andersson <andersson@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/firmware')
-rw-r--r--drivers/firmware/qcom/qcom_scm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 26cd0458aacd..5243d5abbbe9 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -1119,7 +1119,7 @@ int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz,
if (ret) {
dev_err(__scm->dev,
"Assign memory protection call failed %d\n", ret);
- return -EINVAL;
+ return ret;
}
*srcvm = next_vm;