diff options
| author | Jens Axboe <axboe@kernel.dk> | 2025-02-13 08:18:46 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-21 13:57:09 +0100 |
| commit | 99ca540851ee906ae15d36566ed3447e6e415780 (patch) | |
| tree | 8e5493e1992ff7dfd4392a359b866dd41e729508 /drivers/gpio/gpiolib.c | |
| parent | 5a32765ac724517fc26438f52d95a22f4489afcc (diff) | |
| download | linux-99ca540851ee906ae15d36566ed3447e6e415780.tar.gz linux-99ca540851ee906ae15d36566ed3447e6e415780.tar.bz2 linux-99ca540851ee906ae15d36566ed3447e6e415780.zip | |
block: cleanup and fix batch completion adding conditions
[ Upstream commit 1f47ed294a2bd577d5ae43e6e28e1c9a3be4a833 ]
The conditions for whether or not a request is allowed adding to a
completion batch are a bit hard to read, and they also have a few
issues. One is that ioerror may indeed be a random value on passthrough,
and it's being checked unconditionally of whether or not the given
request is a passthrough request or not.
Rewrite the conditions to be separate for easier reading, and only check
ioerror for non-passthrough requests. This fixes an issue with bio
unmapping on passthrough, where it fails getting added to a batch. This
both leads to suboptimal performance, and may trigger a potential
schedule-under-atomic condition for polled passthrough IO.
Fixes: f794f3351f26 ("block: add support for blk_mq_end_request_batch()")
Link: https://lore.kernel.org/r/20575f0a-656e-4bb3-9d82-dec6c7e3a35c@kernel.dk
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/gpio/gpiolib.c')
0 files changed, 0 insertions, 0 deletions