diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2018-06-03 16:40:55 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2018-12-16 22:08:30 +0000 |
| commit | 3a20c56110e8b93b50e3ae3df781e6a0b5d1e85c (patch) | |
| tree | 0f2809ccace148a61a043f10e4c7b0aaa0454386 /drivers/gpu | |
| parent | 4580f31124785043838de3e8ed2c50889b77f11e (diff) | |
| download | linux-3a20c56110e8b93b50e3ae3df781e6a0b5d1e85c.tar.gz linux-3a20c56110e8b93b50e3ae3df781e6a0b5d1e85c.tar.bz2 linux-3a20c56110e8b93b50e3ae3df781e6a0b5d1e85c.zip | |
udl-kms: change down_interruptible to down
commit 8456b99c16d193c4c3b7df305cf431e027f0189c upstream.
If we leave urbs around, it causes not only leak, but also memory
corruption. This patch fixes the function udl_free_urb_list, so that it
always waits for all urbs that are in progress.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/gpu')
| -rw-r--r-- | drivers/gpu/drm/udl/udl_main.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c index 7094b92d1ec7..b0595715a5d1 100644 --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -141,18 +141,13 @@ static void udl_free_urb_list(struct drm_device *dev) struct list_head *node; struct urb_node *unode; struct urb *urb; - int ret; unsigned long flags; DRM_DEBUG("Waiting for completes and freeing all render urbs\n"); /* keep waiting and freeing, until we've got 'em all */ while (count--) { - - /* Getting interrupted means a leak, but ok at shutdown*/ - ret = down_interruptible(&udl->urbs.limit_sem); - if (ret) - break; + down(&udl->urbs.limit_sem); spin_lock_irqsave(&udl->urbs.lock, flags); |