diff options
| author | Qasim Ijaz <qasdev00@gmail.com> | 2025-06-06 19:49:58 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-07-10 15:57:40 +0200 |
| commit | 796abf9f710ae008674936ab499a70f535d8324c (patch) | |
| tree | 79c92bf9067cba7d1704ab34aea9521ab8fda9a2 /drivers/hid | |
| parent | ca7b6d00a713c6fd302f81eaf8453adf9c2cf1d4 (diff) | |
| download | linux-796abf9f710ae008674936ab499a70f535d8324c.tar.gz linux-796abf9f710ae008674936ab499a70f535d8324c.tar.bz2 linux-796abf9f710ae008674936ab499a70f535d8324c.zip | |
HID: wacom: fix memory leak on sysfs attribute creation failure
commit 1a19ae437ca5d5c7d9ec2678946fb339b1c706bf upstream.
When sysfs_create_files() fails during wacom_initialize_remotes() the
fifo buffer is not freed leading to a memory leak.
Fix this by calling kfifo_free() before returning.
Fixes: 83e6b40e2de6 ("HID: wacom: EKR: have the wacom resources dynamically allocated")
Reviewed-by: Ping Cheng <ping.cheng@wacom.com>
Cc: stable@vger.kernel.org
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/wacom_sys.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c index 42f95b00d3ba..88e59f28af90 100644 --- a/drivers/hid/wacom_sys.c +++ b/drivers/hid/wacom_sys.c @@ -2030,6 +2030,7 @@ static int wacom_initialize_remotes(struct wacom *wacom) if (error) { hid_err(wacom->hdev, "cannot create sysfs group err: %d\n", error); + kfifo_free(&remote->remote_fifo); return error; } |