diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2025-07-30 21:38:02 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-08-15 12:14:02 +0200 |
| commit | 89efd90ec67277890b3ddd34b51053420eed9438 (patch) | |
| tree | 0e109ed33e93c705412b4673b78adf32b9df1792 /drivers/i2c | |
| parent | 6038537c4a26761a134ac745f594f63bf555b125 (diff) | |
| download | linux-89efd90ec67277890b3ddd34b51053420eed9438.tar.gz linux-89efd90ec67277890b3ddd34b51053420eed9438.tar.bz2 linux-89efd90ec67277890b3ddd34b51053420eed9438.zip | |
i2c: muxes: mule: Fix an error handling path in mule_i2c_mux_probe()
[ Upstream commit 33ac5155891cab165c93b51b0e22e153eacc2ee7 ]
If an error occurs in the loop that creates the device adapters, then a
reference to 'dev' still needs to be released.
Use for_each_child_of_node_scoped() to both fix the issue and save one line
of code.
Fixes: d0f8e97866bf ("i2c: muxes: add support for tsd,mule-i2c multiplexer")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/muxes/i2c-mux-mule.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/i2c/muxes/i2c-mux-mule.c b/drivers/i2c/muxes/i2c-mux-mule.c index 284ff4afeeac..d3b32b794172 100644 --- a/drivers/i2c/muxes/i2c-mux-mule.c +++ b/drivers/i2c/muxes/i2c-mux-mule.c @@ -47,7 +47,6 @@ static int mule_i2c_mux_probe(struct platform_device *pdev) struct mule_i2c_reg_mux *priv; struct i2c_client *client; struct i2c_mux_core *muxc; - struct device_node *dev; unsigned int readback; int ndev, ret; bool old_fw; @@ -95,7 +94,7 @@ static int mule_i2c_mux_probe(struct platform_device *pdev) "Failed to register mux remove\n"); /* Create device adapters */ - for_each_child_of_node(mux_dev->of_node, dev) { + for_each_child_of_node_scoped(mux_dev->of_node, dev) { u32 reg; ret = of_property_read_u32(dev, "reg", ®); |