summaryrefslogtreecommitdiff
path: root/drivers/infiniband/core
diff options
context:
space:
mode:
authorJason Gunthorpe <jgg@nvidia.com>2020-08-18 15:05:22 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-10-29 09:55:16 +0100
commit0beef934d50822b1cb884f1e7bb115fe0a36a974 (patch)
treeaf8f6a55125c97ea14fb8b95221426f2264c19c7 /drivers/infiniband/core
parentc62998f154356a6708070538ed4221f18ff6be02 (diff)
downloadlinux-0beef934d50822b1cb884f1e7bb115fe0a36a974.tar.gz
linux-0beef934d50822b1cb884f1e7bb115fe0a36a974.tar.bz2
linux-0beef934d50822b1cb884f1e7bb115fe0a36a974.zip
RDMA/ucma: Add missing locking around rdma_leave_multicast()
[ Upstream commit 38e03d092699891c3237b5aee9e8029d4ede0956 ] All entry points to the rdma_cm from a ULP must be single threaded, even this error unwinds. Add the missing locking. Fixes: 7c11910783a1 ("RDMA/ucma: Put a lock around every call to the rdma_cm layer") Link: https://lore.kernel.org/r/20200818120526.702120-11-leon@kernel.org Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/infiniband/core')
-rw-r--r--drivers/infiniband/core/ucma.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index 0c095c8c0ac5..01052de6bedb 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -1476,7 +1476,9 @@ static ssize_t ucma_process_join(struct ucma_file *file,
return 0;
err3:
+ mutex_lock(&ctx->mutex);
rdma_leave_multicast(ctx->cm_id, (struct sockaddr *) &mc->addr);
+ mutex_unlock(&ctx->mutex);
ucma_cleanup_mc_events(mc);
err2:
mutex_lock(&mut);